comment out majority of complexity in publish #743
+252
−90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The publish function only seems to work for publishing package on pypi.org or test.pypi.org and as I'm working primarily with a private company repository this was not ideal. Even though I used Rye for managing the whole project, I had to use Twine in a separate flow to publish the package.
After some initial discussions it turned out that Rye is using twine internally to publish packages, and there were thus no real reason why it was not working. After digging into it, the publish command basically wraps Twine, but it also adds a lot of fairly complicated checks and the parameters given to Twine was hard-coded to be a specific set of arguments adapted to publishing on pypi.org.
Commenting out the absolute majority of the additional command parsing made it work almost directly.
I just need to figure out what the rest of the commented code does and if we can remove it or if we have to adapt it.